fix: run-all-specs opens in new tab rather than new browser #25074

ZachJW34 · 2022-12-08T18:01:16Z

Closes experimentalRunAllSpecs: Replace with new tab when selecting specs rather than closing browser #24919

User facing changelog

Run All Specs will open in a new tab rather than close and reopen the browser

Additional details

Following the same run.ts logic for retaining the browser and switching out the tab with a fresh one.

Steps to test

Choose a project that has Cypress setup and add e2e.experimentalRunAllSpecs = true to the config. Check out this branch, run yarn and the yarn cypress:open. Open up a browser and verify that, after clicking "Run all specs", the browser isn't closed and the current tab is replaced with a new one.

Electron still spawns a new window since there is no "New Tab" in Electron.

Not sure the best way to test this change, since any tests around launchProject require opening and closing browsers.

How has the user experience changed?

Screen.Recording.2022-12-08.at.11.58.07.AM.mov

PR Tasks

Have tests been added/updated?
Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?

cypress-bot · 2022-12-08T18:01:19Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

cypress · 2022-12-08T18:30:56Z

Test summary

25005 • 0 • 2489 • 0 • 21

Run details


Project	cypress
Status	Passed
Commit	`ccaad05`
Started	Dec 8, 2022 10:40 PM
Ended	Dec 8, 2022 10:57 PM
Duration	17:08 💡
OS	Linux Debian -
Browser	Multiple

View run in Cypress Dashboard ➡️

Flakiness

	cypress/e2e/e2e/origin/cookie_behavior.cy.ts		5
1	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2	... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4	... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 21 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

lmiller1990 · 2022-12-08T22:22:21Z

packages/graphql/schemas/schema.graphql

@@ -1255,7 +1255,7 @@ type Mutation {
  internal_clearProjectPreferencesCache(projectTitle: String!): Boolean

  """Launches project from open_project global singleton"""
-  launchOpenProject(specPath: String): CurrentProject
+  launchOpenProject(shouldLaunchNewTab: Boolean, specPath: String): CurrentProject


Something is strange here - the order of the arguments is the opposite on the client mutation? https://github.com/cypress-io/cypress/pull/25074/files#diff-4efefe4d3a02c250b8acd5d08fb87caf32cf883ccff71ea7965d0e6c0448fe68R25

Also, I think it makes sense for the specPath to be first arg, and shouldLaunchNewTab to be second - it follows the usual convention of putting the options as the second argument.

I am surprised this works at all - GraphQL should be erroring, the types don't match.

I think this is just sorted alphabetically (this is generated). Look at:

cloudProjectCreate(campaign: String, ciProviders: [String!], cohort: String, medium: String, name: String!, orgId: ID!, public: Boolean!, source: String): CloudProject

Order doesn't matter since all the args resolve to an args object.

Right, I see. I didn't realize that (and it's quite confusing - the order generally DOES matter in GraphQL, I guess not if you are using Nexus).

…cs-tab

lmiller1990

I tested it out, works great. Curious about the order of the GraphQL mutation arguments, though.

tooling/v8-snapshot/cache/dev-darwin/snapshot-meta.cache.json

lmiller1990 · 2022-12-08T22:25:33Z

packages/graphql/schemas/schema.graphql

@@ -1255,7 +1255,7 @@ type Mutation {
  internal_clearProjectPreferencesCache(projectTitle: String!): Boolean

  """Launches project from open_project global singleton"""
-  launchOpenProject(specPath: String): CurrentProject
+  launchOpenProject(shouldLaunchNewTab: Boolean, specPath: String): CurrentProject


I am surprised this works at all - GraphQL should be erroring, the types don't match.

lmiller1990 · 2022-12-08T23:12:11Z

packages/graphql/schemas/schema.graphql

@@ -1255,7 +1255,7 @@ type Mutation {
  internal_clearProjectPreferencesCache(projectTitle: String!): Boolean

  """Launches project from open_project global singleton"""
-  launchOpenProject(specPath: String): CurrentProject
+  launchOpenProject(shouldLaunchNewTab: Boolean, specPath: String): CurrentProject


Right, I see. I didn't realize that (and it's quite confusing - the order generally DOES matter in GraphQL, I guess not if you are using Nexus).

tooling/v8-snapshot/cache/dev-darwin/snapshot-meta.cache.json

packages/server/lib/makeDataContext.ts

…cs-tab

rockindahizzy

LGTM

lmiller1990 · 2022-12-10T12:40:51Z

Oh, one last thing we should check @ZachJW34 - are videos getting recorded correctly? How does this manifest in Cypress Cloud?

Edit: actually doesn't matter for Cloud, this is open mode only - still relevant locally though, since you can record videos locally (although not as common/useful, worth knowing if/how this works).

astone123

I tested this and it works well 👍🏻

ZachJW34 · 2022-12-12T15:07:52Z

@lmiller1990 you cannot record videos when in open mode. Since this feature is only related to open-mode, this should have no affect on video recording.

cypress-bot · 2022-12-13T00:19:43Z

Released in 12.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.1.0, please open a new issue.

fix: run-all-specs opens in new tab rather than new browser

294e915

ZachJW34 requested review from rockindahizzy and lmiller1990 December 8, 2022 18:07

lmiller1990 reviewed Dec 8, 2022

View reviewed changes

ZachJW34 added 2 commits December 8, 2022 16:28

fix e2e tests

4b77905

Merge remote-tracking branch 'origin/develop' into zachw/run-alls-spe…

ccaad05

…cs-tab

lmiller1990 reviewed Dec 8, 2022

View reviewed changes

lmiller1990 approved these changes Dec 8, 2022

View reviewed changes

rockindahizzy reviewed Dec 9, 2022

View reviewed changes

packages/server/lib/makeDataContext.ts Outdated Show resolved Hide resolved

ZachJW34 added 2 commits December 9, 2022 15:04

Merge remote-tracking branch 'origin/develop' into zachw/run-alls-spe…

5daf207

…cs-tab

reset server rather than project

5246898

rockindahizzy approved these changes Dec 9, 2022

View reviewed changes

astone123 approved these changes Dec 12, 2022

View reviewed changes

ZachJW34 merged commit 6c37403 into develop Dec 12, 2022

ZachJW34 deleted the zachw/run-alls-specs-tab branch December 12, 2022 15:08

cypress-bot bot mentioned this pull request Dec 12, 2022

experimentalRunAllSpecs: Replace with new tab when selecting specs rather than closing browser #24919

Closed

flotwig pushed a commit that referenced this pull request Dec 12, 2022

fix: run-all-specs opens in new tab rather than new browser (#25074)

a11eccb

cypress-bot bot locked as resolved and limited conversation to collaborators Dec 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: run-all-specs opens in new tab rather than new browser #25074

fix: run-all-specs opens in new tab rather than new browser #25074

ZachJW34 commented Dec 8, 2022 •

edited

Loading

cypress-bot bot commented Dec 8, 2022

cypress bot commented Dec 8, 2022 •

edited

Loading

lmiller1990 Dec 8, 2022

lmiller1990 Dec 8, 2022

ZachJW34 Dec 8, 2022 •

edited

Loading

lmiller1990 Dec 8, 2022

lmiller1990 left a comment

lmiller1990 Dec 8, 2022

lmiller1990 Dec 8, 2022

rockindahizzy left a comment

lmiller1990 commented Dec 10, 2022 •

edited

Loading

astone123 left a comment

ZachJW34 commented Dec 12, 2022

cypress-bot bot commented Dec 13, 2022

fix: run-all-specs opens in new tab rather than new browser #25074

fix: run-all-specs opens in new tab rather than new browser #25074

Conversation

ZachJW34 commented Dec 8, 2022 • edited Loading

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

cypress-bot bot commented Dec 8, 2022

cypress bot commented Dec 8, 2022 • edited Loading

Test summary

Run details

Flakiness

lmiller1990 Dec 8, 2022

Choose a reason for hiding this comment

lmiller1990 Dec 8, 2022

Choose a reason for hiding this comment

ZachJW34 Dec 8, 2022 • edited Loading

Choose a reason for hiding this comment

lmiller1990 Dec 8, 2022

Choose a reason for hiding this comment

lmiller1990 left a comment

Choose a reason for hiding this comment

lmiller1990 Dec 8, 2022

Choose a reason for hiding this comment

lmiller1990 Dec 8, 2022

Choose a reason for hiding this comment

rockindahizzy left a comment

Choose a reason for hiding this comment

lmiller1990 commented Dec 10, 2022 • edited Loading

astone123 left a comment

Choose a reason for hiding this comment

ZachJW34 commented Dec 12, 2022

cypress-bot bot commented Dec 13, 2022

ZachJW34 commented Dec 8, 2022 •

edited

Loading

cypress bot commented Dec 8, 2022 •

edited

Loading

ZachJW34 Dec 8, 2022 •

edited

Loading

lmiller1990 commented Dec 10, 2022 •

edited

Loading