Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimentalRunAllSpecs: Replace with new tab when selecting specs rather than closing browser #24919

Closed
ZachJW34 opened this issue Dec 1, 2022 · 2 comments · Fixed by #25074
Closed

experimentalRunAllSpecs: Replace with new tab when selecting specs rather than closing browser #24919

ZachJW34 opened this issue Dec 1, 2022 · 2 comments · Fixed by #25074
Assignees
@ZachJW34
Labels
CT Issue related to component testing experimental: run all specs

Comments

@ZachJW34
Copy link
Contributor

ZachJW34 commented Dec 1, 2022 •
edited

Current behavior

When you select a new subset of specs to run with the "Run All Specs" feature, the browser closes and reopens. Not only is this not performant, it also exacerbates #21743 where the Chrome browser is unable to focus properly.

Desired behavior

Similar to run-mode, the browser should not close but rather the tab should be replaced with a new tab.
@ZachJW34 ZachJW34 added experimental: run all specs CT Issue related to component testing labels Dec 1, 2022
@ZachJW34 ZachJW34 self-assigned this Dec 7, 2022
@ZachJW34 ZachJW34 mentioned this issue Dec 8, 2022
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: review and removed stage: in progress stage: needs review The PR code is done & tested, needs review labels Dec 8, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 12, 2022

The code for this is done in cypress-io/cypress#25074, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 13, 2022

Released in 12.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZachJW34 ZachJW34

Labels
CT Issue related to component testing experimental: run all specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: run-all-specs opens in new tab rather than new browser cypress-io/cypress
1 participant
@ZachJW34