Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit CI runs #24755

Merged
merged 66 commits into from Nov 22, 2022
Merged

chore: limit CI runs #24755

merged 66 commits into from Nov 22, 2022

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Nov 21, 2022

Rules

  • always run on PRs ready-for-review and protected branched
  • allow CI on any branch run when explicitly opt'd into when commit message includes "run ci"
  • allow CI when pipeline is manually triggered from CircleCI UI via Trigger Pipeline button

Changes

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 21, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough marked this pull request as ready for review November 21, 2022 17:20
@@ -0,0 +1,2898 @@
version: 2.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is 1:1 with the previous config.yml file. CircelCI uses config.yml by default. This change is to simple limit kicking off the workflows. Over time, plan to make enhancements to the dynamic configuration to simplify this setup.

@emilyrohrbough emilyrohrbough self-assigned this Nov 21, 2022
@emilyrohrbough emilyrohrbough changed the title chore: limit CI builds on WIP branches chore: limit CI runs Nov 21, 2022
@cypress
Copy link

cypress bot commented Nov 21, 2022



Test summary

9090 0 1462 0Flakiness 1


Run details

Project cypress
Status Passed
Commit a835918
Started Nov 22, 2022 8:31 PM
Ended Nov 22, 2022 8:48 PM
Duration 16:58 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@@ -1,2907 +1,70 @@
version: 2.1
setup: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tips to review this PR? There's a lot of red and green, but I suspect the code changes are quite minimal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows.yml should be 1:1 copy of config.yml in develop, so copy & paste and see nothing changed? I was bummed the diff on config.yml was so rough. config.yml is all new content

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, ok, so I just need to really look at

cancel_build () {
for new code.

Bash is gnarly, if it works it works -- cool hack on downloading the workflows.yml:

curl -o workflows.yml https://raw.githubusercontent.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/${CIRCLE_BRANCH}/.circleci/workflows.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see little to no risk in this change, so ✔️

@lmiller1990 lmiller1990 self-requested a review November 21, 2022 22:34
# Conflicts:
#	.circleci/config.yml
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We should probably announce a summary of these changes in Slack just so that people know what's going on 👍🏻

# Conflicts:
#	.circleci/config.yml
@emilyrohrbough emilyrohrbough merged commit b2ee525 into develop Nov 22, 2022
@emilyrohrbough emilyrohrbough deleted the emily/dynamic-cirlce-ci branch November 22, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants