fix(sessions): correct when page is cleared in cy.session() #24563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s clear at end of command
|
Thanks for taking the time to open a PR!
|
emilyrohrbough
changed the title
# Conflicts: # packages/driver/cypress/e2e/commands/sessions/sessions.cy.js # packages/driver/src/cy/commands/sessions/index.ts
chrisbreiding
approved these changes
Nov 10, 2022
…d loading. Caused log to be unassociated with cy.session()
AtofStryker
approved these changes
Nov 14, 2022
mschile
reviewed
Nov 14, 2022
| @@ -194,13 +194,18 @@ const getPostMessageLocalStorage = (specWindow, origins): Promise<any[]> => { | |||
| } | |||
|
|
|||
| function navigateAboutBlank (session: boolean = true) { | |||
There was a problem hiding this comment.
Suggested change
| function navigateAboutBlank (session: boolean = true) { | |
| function maybeNavigateAboutBlank (session: boolean = true) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
The session command no longer clears the page between setup and validation and will now always clear the page at the end of the command when test isolation is
on. Fixes #21397.How has the user experience changed?
The session command no longer clear the page between setup and validation and will now alway clear the page at the end of the command when test isolation is
on.PR Tasks
cypress-documentation? Update cy.session() page clearing docs cypress-documentation#4841type definitions?