Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sessions] Evaluate & Update Clear Page System Event Logs #21397

Closed
emilyrohrbough opened this issue May 9, 2022 · 6 comments · Fixed by #24563
Closed

[sessions] Evaluate & Update Clear Page System Event Logs #21397

emilyrohrbough opened this issue May 9, 2022 · 6 comments · Fixed by #24563
Assignees
Labels
E2E Issue related to end-to-end testing topic: auth topic: session Issues when using session command

Comments

@emilyrohrbough
Copy link
Member

What would you like?

Sync notes:

  • Clear Page
  • Redesign or remove this? TBD
    • Brian: i think we should keep this
  • Why is there an extra Clear Page at the very end of the session?

Why is this needed?

Clearly indicate to users when and why we are clearing the page and removing session data. Current messaging and number of clear pages are confusing.

Other

No response

@emilyrohrbough emilyrohrbough self-assigned this May 9, 2022
@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label May 9, 2022
@emilyrohrbough emilyrohrbough removed the topic: session Issues when using session command label Sep 6, 2022
@emilyrohrbough emilyrohrbough removed their assignment Sep 6, 2022
@emilyrohrbough emilyrohrbough self-assigned this Sep 6, 2022
@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label Sep 6, 2022
@emilyrohrbough
Copy link
Member Author

emilyrohrbough commented Oct 5, 2022

  1. Remove clearing the page before the validate (on create)
    1. Users don’t understand that validate purges the cache
    2. Users will DRY up code
  2. Always clear the page at the end of the command - Revert the most recent change that removed that final “clear page”
    1. This restores the original specification

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: internal labels Nov 7, 2022
@nagash77 nagash77 added E2E Issue related to end-to-end testing topic: auth and removed E2E-auth labels Nov 8, 2022
@duplessc
Copy link

duplessc commented Nov 10, 2022

So I have set experimentalSessionAndOrigin:true and testIsolation: "off" but when creating the session it still ends up clearing the page.

Cypress: 11.0.1
Node: 14.17.4
Chrome: 103

image

Code:
image

@emilyrohrbough
Copy link
Member Author

@duplessc I was unable to repo the Clear Page with the code sample provided. Can you share a small repo?

@duplessc
Copy link

duplessc commented Nov 11, 2022

@duplessc I was unable to repo the Clear Page with the code sample provided. Can you share a small repo?

@emilyrohrbough unfortunately no. I have to recreate a repo with just this command in it. I'd be happy sharing other details I can if needed

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 15, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 15, 2022

The code for this is done in cypress-io/cypress#24563, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 22, 2022

Released in 11.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E Issue related to end-to-end testing topic: auth topic: session Issues when using session command
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants