fix(svelte): default mount log to true #23771
Conversation
|
Thanks for taking the time to open a PR!
|
ZachJW34
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
| @@ -76,7 +76,7 @@ export function mount<T extends SvelteComponent> ( | |||
| // by waiting, we are delaying test execution for the next tick of event loop | |||
| // and letting hooks and component lifecycle methods to execute mount | |||
| return cy.wait(0, { log: false }).then(() => { | |||
| if (options.log) { | |||
| if (options.log !== false) { | |||
There was a problem hiding this comment.
Nice, all our adapters do this - this could be part of GA, the standard API that adapters must comply with. Part of that could be logging the component name, and we could enforce it via an interface or something.
| .within(() => | ||
| cy | ||
| .get(".command-name-mount") | ||
| .should("contain", "mount<Counter ... />") |
There was a problem hiding this comment.
Maybe it would be helpful for future us to add a comment detailing the fact there is no space here purposefully, but I'm not too concerned with it.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Logs the Svelte mount command by default
Additional details
The mount log should default to true, but we missed the fallback. Found when pairing with @rockindahizzy (thanks Rocky!)
Steps to test
Throw a
.onlyon svelte component testing and runyarn workspace @tooling/system-tests test component_testing_spec.ts --no-exit --headed, or test locally against a Svelte app. Check the reporter for amount <MyComponent ...>log.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?