fix(svelte): default mount log to true (#23771)

cypress-io · Sep 12, 2022 · 96b03ab · 96b03ab · cypress-bot · Sep 12, 2022
1 parent f07a49b
commit 96b03ab
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/npm/svelte/src/mount.ts b/npm/svelte/src/mount.ts
@@ -76,7 +76,7 @@ export function mount<T extends SvelteComponent> (
     // by waiting, we are delaying test execution for the next tick of event loop
     // and letting hooks and component lifecycle methods to execute mount
     return cy.wait(0, { log: false }).then(() => {
-      if (options.log) {
+      if (options.log !== false) {
         const mountMessage = `<${getComponentDisplayName(Component)} ... />`
 
         Cypress.log({

diff --git a/system-tests/project-fixtures/svelte/src/mount.cy.js b/system-tests/project-fixtures/svelte/src/mount.cy.js
@@ -53,4 +53,34 @@ describe("Svelte mount", () => {
     cy.then(() => messageStore.set("Written from spec"));
     cy.contains("h1", "Written from spec");
   });
+
+  context("log", () => {
+    it("displays component name in mount log", () => {
+      cy.mount(Counter);
+
+      cy.wrap(Cypress.$(window.top.document.body)).within(() =>
+        cy
+          .contains("displays component name in mount log")
+          .closest(".collapsible")
+          .click()
+          .within(() =>
+            cy
+              .get(".command-name-mount")
+              .should("contain", "mount<Counter ... />")
+          )
+      );
+    });
+
+    it("does not display mount log", () => {
+      cy.mount(Counter, { log: false });
+
+      cy.wrap(Cypress.$(window.top.document.body)).within(() =>
+        cy
+          .contains("does not display mount log")
+          .closest(".collapsible")
+          .click()
+          .within(() => cy.get(".command-name-mount").should("not.exist"))
+      );
+    });
+  });
 });