Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding record key context for internal ui jobs #22559

Merged
merged 2 commits into from Jun 28, 2022

Conversation

tbiethman
Copy link
Contributor

@tbiethman tbiethman commented Jun 28, 2022

User facing changelog

N/A

Additional details

With 9101a90, we added a dependency on a new context to all the run-new-ui-tests jobs. Without this context set, we'd fall into the external contributor build logic, which seems like it might be the source of a few new failures we're seeing.

Steps to test

Gotta watch the build

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 28, 2022

Thanks for taking the time to open a PR!

@tbiethman tbiethman marked this pull request as ready for review June 28, 2022 15:11
@cypress
Copy link

cypress bot commented Jun 28, 2022



Test summary

4375 0 51 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 5081b08
Started Jun 28, 2022 3:35 PM
Ended Jun 28, 2022 3:46 PM
Duration 11:43 💡
OS Linux Debian - 10.11
Browser Firefox 98

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34
Copy link
Contributor

ZachJW34 commented Jun 28, 2022

There are some windows jobs that use run-new-ui-tests, should we add the context there?

https://app.circleci.com/pipelines/github/cypress-io/cypress/40062/workflows/63f5003b-5046-4236-929b-edd7f27ec165/jobs/1643898

I was looking into this as well 😅 #22561

@mjhenkes mjhenkes merged commit f902b96 into develop Jun 28, 2022
@mjhenkes mjhenkes deleted the tbiethman-patch-1 branch June 28, 2022 16:27
@tbiethman
Copy link
Contributor Author

@ZachJW34 you are correct. It doesn't seem like those missing contexts impact the windows builds at the moment, so we'll prioritize merging this and getting the release going. But I'll circle back around on these post-release. I appreciate the call-out and follow up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants