Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): filter CertVerifyProcBuiltin from stderr #22342

Merged
merged 3 commits into from Jun 17, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 15, 2022

User facing changelog

  • Suppressed a misleading Chromium warning about CertVerifyProcBuiltin that would appear when visiting HTTPS sites in Cypress.

Additional details

Steps to test

  • Visit an HTTPS site in Cypress and observe no stderr about CertVerifyProcBuiltin.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 15, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 15, 2022



Test summary

37552 1 454 0Flakiness 3


Run details

Project cypress
Status Failed
Commit a291e40
Started Jun 17, 2022 3:57 PM
Ended Jun 17, 2022 4:15 PM
Duration 18:46 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/e2e/origin/commands/assertions.cy.ts Failed
1 cy.origin assertions > #consoleProps > .should() and .and()

Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review June 15, 2022 19:58
@flotwig flotwig requested a review from a team as a code owner June 15, 2022 19:58
@flotwig flotwig requested review from jennifer-shehane, rachelruderman and tbiethman and removed request for a team and jennifer-shehane June 15, 2022 19:58
// ERROR: No matching issuer found
const isCertVerifyProcBuiltin = /(^\[.*ERROR:cert_verify_proc_builtin\.cc|^----- Certificate i=0 \(OU=Cypress Proxy|^ERROR: No matching issuer found$)/

const GARBAGE_WARNINGS = [isXlibOrLibudevRe, isHighSierraWarningRe, isRenderWorkerRe, isDbusWarning, isCertVerifyProcBuiltin]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol garbage warnings ❤️

Copy link
Contributor

@rachelruderman rachelruderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the latest from develop in and now we've got way more failures 🥲 they look unrelated though so throwing this approval your way!

@flotwig flotwig merged commit 152e828 into develop Jun 17, 2022
@flotwig flotwig deleted the issue-22128-certverifyprocbuiltin branch June 17, 2022 19:10
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 21, 2022

Released in 10.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants