chore(packages/sui-test-e2e): Update Cypress to version 10.2.0 #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oegea
requested review from
midudev,
kikoruiz,
rmoralp and
sui-bot
as code owners
jordevo
reviewed
Jun 13, 2022
Released the version |
|
In order to test these changes in CI, I've tried to publish a docker image running the beta version, pushed without the I'll keep posting updates here! |
|
We've published a docker image (with a personal user, just for testing purposes), which name is Thanks a lot to @jordevo for the help during the publishing process 🥇 🙇♂️ |
oegea
changed the title
midudev
approved these changes
Jun 23, 2022
jmanrumartinez
approved these changes
Jun 23, 2022
jordevo
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
👉 How to test in local: Install the version
1.11.0-beta.1of@s-ui/test-e2epackage to test these changes.👉 How to test in CI: Modify the CI job to use the
oegeaadevinta/e2e-test:cypress-10docker image instead ofsuitools/e2e-testAll of these should be temporary changes, just to check that your e2e tests run as expected after the update.
--
As part of the
end2end reborninitiative, from the motor vertical, we have concluded that upgrading Cypress to the latest version available could be a good way to improve stability and performance of our end to end tests (among other actions), and additionally a way to get more useful features that aren't available on version8.7.0.This PR introduces some changes to the
@s-ui/test-e2epackage to adopt the last Cypress version, which is the10.2.0version.This is still a proof of concept, and we're currently performing some tests to ensure that tests keep working as expected after this changes.
If you want to know more about this action and how it is related with the end2end reborn initiative, please refer to this document
Related to compatibility:
Apparently, there are not breaking changes (we have tested it in coches.net and coches.net pro without modifying anything). However, as a side effect, a basic
cypress.config.jsfile will be created on every project updated to Cypress 10. Until now we had theconfigFileparameter set tofalseto avoid creating configuration files, however, since Cypress 10, having that file seems to be mandatory.Known Problems:
Related Issue