Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distribute files to machines for external contributors. #22326

Merged
merged 20 commits into from Jun 27, 2022

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Jun 15, 2022

User facing changelog

It's not a feature. It's a change for external contributors. Distribute files to machines for faster and less-flaky CI experience.

Additional details

Steps to test

Check this CI result.

How has the user experience changed?

N/A

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 15, 2022

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review June 15, 2022 04:36
@sainthkh sainthkh marked this pull request as draft June 15, 2022 04:38
@sainthkh sainthkh marked this pull request as ready for review June 16, 2022 06:44
@sainthkh
Copy link
Contributor Author

Now, CI distributes test files to machines.

I intentionally left run-reporter-component failed, because it has only 2 test files but has 7 machines. I think it's a bug in the CI setting, not the CI script.

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

circle.yml Show resolved Hide resolved
fix error
fix
fix
test
TEST
This reverts commit 21a8ad9.
@cypress
Copy link

cypress bot commented Jun 27, 2022



Test summary

4904 0 63 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 42dbe54
Started Jun 27, 2022 10:54 PM
Ended Jun 27, 2022 11:08 PM
Duration 13:57 💡
OS Linux Debian - 10.11
Browser Firefox 98

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor

lmiller1990 commented Jun 27, 2022

The CI failure was happening locally, too. I tried pushing a commit to get it over the line: 42dbe54. 🤞

Edit: It worked

@lmiller1990 lmiller1990 merged commit 9101a90 into cypress-io:develop Jun 27, 2022
lmiller1990 added a commit that referenced this pull request Jun 28, 2022
* fix: distribute files to machines for external contributors.

* fix path

* fix

* fix glob

* fix

* fix glob pattern spec->cy.

* fix

* echo things.

* test

* use cd.

* fix component tests.

* test

* test

* fix

* refactor

* test distribut-step

fix error
fix
fix
test
TEST

* Revert "test distribut-step"

This reverts commit 15c3606.

* Revert "refactor"

This reverts commit 21a8ad9.

* reduce flake by increasing viewport height

Co-authored-by: Ryan Manuel <ryanm@cypress.io>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
tgriesser added a commit that referenced this pull request Jun 28, 2022
…est-runs-batching

* develop:
  fix: add baseUrl to TestConfigOverrides (#22445)
  fix: distribute files to machines for external contributors. (#22326)
  feat: Display Cypress Dashboard metrics in the Specs Explorer (#21250)
mjhenkes pushed a commit that referenced this pull request Jun 28, 2022
* fix: distribute files to machines for external contributors. (#22326)

* fix: distribute files to machines for external contributors.

* fix path

* fix

* fix glob

* fix

* fix glob pattern spec->cy.

* fix

* echo things.

* test

* use cd.

* fix component tests.

* test

* test

* fix

* refactor

* test distribut-step

fix error
fix
fix
test
TEST

* Revert "test distribut-step"

This reverts commit 15c3606.

* Revert "refactor"

This reverts commit 21a8ad9.

* reduce flake by increasing viewport height

Co-authored-by: Ryan Manuel <ryanm@cypress.io>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>

* fix: add baseUrl to TestConfigOverrides (#22445)

Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>

* handle white space when registering ts-node using --require

* update test project

* move config

Co-authored-by: Kukhyeon Heo <sainthkh@naver.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
Co-authored-by: Ishan Madhusanka <ahtimadhusanka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: External contributions are not distributed properly causing long and flaky builds
4 participants