Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sessions] Improve Validation Error UI in Recreated Session #21398

Closed
emilyrohrbough opened this issue May 9, 2022 · 2 comments · Fixed by #24511
Closed

[sessions] Improve Validation Error UI in Recreated Session #21398

emilyrohrbough opened this issue May 9, 2022 · 2 comments · Fixed by #24511
Assignees
@emilyrohrbough
Labels
E2E Issue related to end-to-end testing topic: auth topic: session Issues when using session command
Milestone
experimentalSessi...

Comments

@emilyrohrbough
Copy link
Member

emilyrohrbough commented May 9, 2022 •
edited

What would you like?

The cy.session command is re-using the test error component to share details when a session failed validation and the cy.session command catches the error to then recreate the session. This is a bit unexpected in the UI and we'd like to update the UI to display these details differently.

Current UI (10.0 visuals):

Screen Shot 2022-05-09 at 9 20 22 AM

Designs

https://www.figma.com/file/E86dG4e1dcuyRe33B2j3zU/app-reporter%3A-sessions?node-id=17733%3A151907
@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label May 9, 2022
@emilyrohrbough emilyrohrbough self-assigned this May 9, 2022
@emilyrohrbough emilyrohrbough changed the title [sessions] Improve Validation Error in Command Log [sessions] Improve Validation Error UI in Recreated Session May 9, 2022
@emilyrohrbough emilyrohrbough self-assigned this Aug 11, 2022
@emilyrohrbough emilyrohrbough mentioned this issue Oct 14, 2022
Merged
2 tasks
@emilyrohrbough emilyrohrbough mentioned this issue Nov 2, 2022
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: new stage: needs review The PR code is done & tested, needs review and removed stage: internal stage: needs review The PR code is done & tested, needs review labels Nov 2, 2022
@nagash77 nagash77 added E2E Issue related to end-to-end testing topic: auth and removed E2E-auth labels Nov 8, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2022

The code for this is done in cypress-io/cypress#24511, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 15, 2022

Released in 11.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emilyrohrbough emilyrohrbough

Labels
E2E Issue related to end-to-end testing topic: auth topic: session Issues when using session command
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
Development

Successfully merging a pull request may close this issue.

fix: Recovered Error Handling and Session Recovered Errors cypress-io/cypress
3 participants
@nagash77 @mjhenkes @emilyrohrbough