fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it #19282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
legap
changed the title
ryanthemanuel
requested review from
mjhenkes
and removed request for
flotwig
mjhenkes
approved these changes
Dec 14, 2021
tbiethman
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Thank you @legap! We will update the docs to account for this new variable and get this change in.
Doc PR: cypress-io/cypress-documentation#4271
tgriesser
added a commit
that referenced
this pull request
Dec 21, 2021
…ert-with-stack * tgriesser/10.0-release/refactor-lifecycle: (50 commits) Remove unused test file update task spec to use correct projectRoot update Fix test Fix test Fix tests update tests fix test correct config path Fix TS resolve conflicts Fixing component & e2e tests build: fix dev process on windows (#19401) fix: `cy.contains()` ignores `<style>` and `<script>` without removing them. (#19424) Fix some tests chore: Fix the broken codeowners automation (#19431) chore: add types for Cypress.session.clearAllSavedSessions (#19412) fix: No unnecessary snapshotting (#19311) chore: Remove pkg/driver @ts-nocheck part 1 (#19353) fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it (#19282) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an extension to PR 18243 initiated by Luke Page. It uses the same implementation and adds a test for the default and custom timeout.
User facing changelog
You can now override the verification timeout for slow machines with the environment variable
CYPRESS_VERIFY_TIMEOUT. It defaults to 30000 milliseconds but in some circumstances it can take up to 60000 milliseconds.Additional details
See linked issues
How has the user experience changed?
PR Tasks
cypress-documentation? PR #4261 & PR #4271type definitions?cypress.schema.json?