Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
flotwig committed Dec 6, 2022
1 parent 3f5f43c commit bd64fe6
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/driver/cypress/e2e/commands/navigation.cy.js
Expand Up @@ -1803,7 +1803,7 @@ describe('src/cy/commands/navigation', () => {
})
})

// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
context('#page load', { browser: '!webkit' }, () => {
it('sets initial=true and then removes', () => {
Cookie.remove('__cypress.initial')
Expand Down Expand Up @@ -2200,7 +2200,7 @@ describe('src/cy/commands/navigation', () => {
})
})

// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
context('#url:changed', { browser: '!webkit' }, () => {
beforeEach(function () {
this.logs = []
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts
Expand Up @@ -49,7 +49,7 @@ describe('Proxy Logging', () => {
it('fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps', {
// TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23443
retries: 15,
// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
browser: '!webkit',
}, (done) => {
fetch('/some-url')
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/e2e/focus_blur.cy.js
Expand Up @@ -509,7 +509,7 @@ describe('polyfill programmatic blur events', () => {
})
})

// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
describe('intercept blur methods correctly', { browser: '!webkit' }, () => {
beforeEach(() => {
cy.visit('http://localhost:3500/fixtures/active-elements.html').then(() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/e2e/react-15.cy.js
@@ -1,4 +1,4 @@
// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
describe('react v15.6.0', { browser: '!webkit' }, () => {
context('fires onChange events', () => {
beforeEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/e2e/react-16.cy.js
@@ -1,4 +1,4 @@
// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
describe('react v16.0.0', { browser: '!webkit' }, () => {
context('fires onChange events', () => {
beforeEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/e2e/text_mask.cy.js
@@ -1,6 +1,6 @@
let changed = 0

// TODO(webkit): fix+unskip for experimental webkit release
// TODO(webkit): fix+unskip for webkit release
describe('src/cy/commands/actions/type text_mask_spec', { browser: '!webkit' }, () => {
beforeEach(() => {
cy.visit('/fixtures/text-mask.html')
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/issues/1244.cy.js
Expand Up @@ -11,7 +11,7 @@ describe('issue 1244', () => {

for (const [el, target, action] of [['button', 'form', 'submit'], ['a', 'a', 'click']]) {
// <form> submit, <a> click
// TODO(webkit): fix+unskip for experimental webkit release, or make skip more specific (only 4 of these generated tests fail in webkit)
// TODO(webkit): fix+unskip for webkit release, or make skip more specific (only 4 of these generated tests fail in webkit)
describe(`<${target}> ${action}`, { browser: '!webkit' }, () => {
it('correctly redirects when target=_top with target.target =', () => {
cy.get(`${el}.setTarget`).click()
Expand Down

0 comments on commit bd64fe6

Please sign in to comment.