fix: warn when the projectRoot is not writeable (#18495)

closes #18485
cypress-io · Oct 14, 2021 · 83a1f09 · 83a1f09 · cypress-bot · Oct 14, 2021
1 parent af472b6
commit 83a1f09
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/packages/server/lib/modes/run.js b/packages/server/lib/modes/run.js
@@ -608,9 +608,22 @@ const openProjectCreate = (projectRoot, socketId, args) => {
   return openProject.create(projectRoot, args, options)
 }
 
-const createAndOpenProject = async function (socketId, options) {
+async function checkAccess (folderPath) {
+  return fs.access(folderPath, fs.W_OK).catch((err) => {
+    if (['EACCES', 'EPERM'].includes(err.code)) {
+      // we cannot write due to folder permissions
+      return errors.warning('FOLDER_NOT_WRITABLE', folderPath)
+    }
+
+    throw err
+  })
+}
+
+const createAndOpenProject = async (socketId, options) => {
   const { projectRoot, projectId } = options
 
+  await checkAccess(projectRoot)
+
   return openProjectCreate(projectRoot, socketId, options)
   .then((open_project) => open_project.getProject())
   .then((project) => {

diff --git a/packages/server/test/e2e/non_root_read_only_fs_spec.ts b/packages/server/test/e2e/non_root_read_only_fs_spec.ts
@@ -8,6 +8,9 @@ describe('e2e readonly fs', function () {
 
   const projectPath = Fixtures.projectPath('read-only-project-root')
 
+  /**
+   * Change permissions recursively
+   */
   const chmodr = (p: string, mode: number) => {
     const stats = fs.statSync(p)
 

diff --git a/packages/server/test/unit/modes/run_spec.js b/packages/server/test/unit/modes/run_spec.js
@@ -662,6 +662,7 @@ describe('lib/modes/run', () => {
       sinon.stub(random, 'id').returns(1234)
       sinon.stub(openProject, 'create').resolves(openProject)
       sinon.stub(runMode, 'waitForSocketConnection').resolves()
+      sinon.stub(fs, 'access').resolves()
       sinon.stub(runMode, 'waitForTestsToFinishRunning').resolves({
         stats: { failures: 10 },
         spec: {},
@@ -736,6 +737,7 @@ describe('lib/modes/run', () => {
 
       sinon.stub(electron.app, 'on').withArgs('ready').yieldsAsync()
       sinon.stub(user, 'ensureAuthToken')
+      sinon.stub(fs, 'access').resolves()
       sinon.stub(random, 'id').returns(1234)
       sinon.stub(openProject, 'create').resolves(openProject)
       sinon.stub(system, 'info').resolves({ osName: 'osFoo', osVersion: 'fooVersion' })