retry video compression in wk

cypress-io · Dec 9, 2022 · 7e59bf9 · 7e59bf9 · cypress-bot · Dec 9, 2022
1 parent bc7dbe2
commit 7e59bf9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/system-tests/lib/system-tests.ts b/system-tests/lib/system-tests.ts
@@ -55,6 +55,7 @@ export type ItOptions = ExecOptions & {
    * If a function is supplied, it will be executed instead of running the `systemTests.exec` function immediately.
    */
   onRun?: (
+    this: Mocha.Context,
     execFn: ExecFn,
     browser: BrowserName
   ) => Promise<any> | any
@@ -528,7 +529,8 @@ const localItFn = function (title: string, opts: ItOptions) {
         return systemTests.exec(ctx, _.extend({ originalTitle }, options, overrides, { browser }))
       }
 
-      return options.onRun(execFn, browser, ctx)
+      // pass Mocha's this context to onRun
+      return options.onRun.call(this, execFn, browser, ctx)
     })
   }
 

diff --git a/system-tests/test/video_compression_spec.js b/system-tests/test/video_compression_spec.js
@@ -49,7 +49,12 @@ describe('e2e video compression', () => {
           MS_PER_TEST,
         },
       },
-      async onRun (exec) {
+      async onRun (exec, browserName) {
+        if (browserName === 'webkit') {
+          // TODO(webkit): fix video recording flake in webkit
+          this.retries(15)
+        }
+
         process.env.VIDEO_COMPRESSION_THROTTLE = 10
 
         const { stdout } = await exec()