Skip to content

Commit

Permalink
add comment and partially fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
flotwig committed Dec 5, 2022
1 parent 7d9dfc1 commit 74bd56b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/server/test/integration/cypress_spec.js
Expand Up @@ -1747,9 +1747,11 @@ describe('lib/cypress', () => {
// this should be overridden by the env argument
json.baseUrl = 'http://localhost:8080'

const { supportFile, specPattern, excludeSpecPattern, baseUrl, slowTestThreshold, testIsolation, ...rest } = json
// "pick" out the list of properties that cannot exist on the root level so we can re-add them on the "e2e" object
// TODO: refactor this part of the test, this is silly and a holdover from pre-split-config
const { experimentalRunAllSpecs, experimentalOriginDependencies, supportFile, specPattern, excludeSpecPattern, baseUrl, slowTestThreshold, testIsolation, ...rest } = json

return settings.writeForTesting(this.todosPath, { ...rest, e2e: { baseUrl, supportFile, specPattern, testIsolation, excludeSpecPattern } })
return settings.writeForTesting(this.todosPath, { ...rest, e2e: { experimentalRunAllSpecs, experimentalOriginDependencies, baseUrl, supportFile, specPattern, testIsolation, excludeSpecPattern } })
}).then(async () => {
await clearCtx()

Expand Down

0 comments on commit 74bd56b

Please sign in to comment.