fix: Restart server on blockHost configuration change (#24257)

Co-authored-by: Bill Glesias <bglesias@gmail.com>
cypress-io · Oct 14, 2022 · 582ab6c · 582ab6c · cypress-bot · Oct 14, 2022
1 parent fa21345
commit 582ab6c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/packages/config/src/options.ts b/packages/config/src/options.ts
@@ -141,6 +141,7 @@ const driverConfigOptions: Array<DriverConfigOption> = [
     defaultValue: null,
     validation: validate.isStringOrArrayOfStrings,
     overrideLevel: 'any',
+    requireRestartOnChange: 'server',
   }, {
     name: 'chromeWebSecurity',
     defaultValue: true,

diff --git a/packages/config/test/index.spec.ts b/packages/config/test/index.spec.ts
@@ -231,4 +231,15 @@ describe('config/src/index', () => {
       expect(errorFn).to.have.callCount(0)
     })
   })
+
+  describe('.validateNeedToRestartOnChange', () => {
+    it('returns the need to restart if given key has changed', () => {
+      const result = configUtil.validateNeedToRestartOnChange({ blockHosts: [] }, { blockHosts: ['https://example.com'] })
+
+      expect(result).to.eql({
+        server: true,
+        browser: false,
+      })
+    })
+  })
 })