fix: Plugin error when sending on disconnected IPC channel (#21011)

* fix: Plugin error when sending on disconnected IPC channel * Add unit test for new no send behaviour Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
cypress-io · Apr 13, 2022 · 57dbc17 · 57dbc17 · cypress-bot · Apr 13, 2022
1 parent 476f2ad
commit 57dbc17
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/server/lib/plugins/util.js b/packages/server/lib/plugins/util.js
@@ -25,7 +25,7 @@ module.exports = {
 
     return {
       send (event, ...args) {
-        if (aProcess.killed) {
+        if (aProcess.killed || !aProcess.connected) {
           return
         }
 

diff --git a/packages/server/test/unit/plugins/util_spec.js b/packages/server/test/unit/plugins/util_spec.js
@@ -10,6 +10,7 @@ describe('lib/plugins/util', () => {
       this.theProcess = {
         send: sinon.spy(),
         on: sinon.stub(),
+        connected: true,
       }
 
       this.ipc = util.wrapIpc(this.theProcess)
@@ -31,6 +32,13 @@ describe('lib/plugins/util', () => {
       expect(this.theProcess.send).not.to.be.called
     })
 
+    it('#send does not send if process has been disconnected', function () {
+      this.theProcess.connected = false
+      this.ipc.send('event-name')
+
+      expect(this.theProcess.send).not.to.be.called
+    })
+
     it('#on listens for process messages that match event', function () {
       const handler = sinon.spy()