Skip to content

Commit

Permalink
note persistent failures
Browse files Browse the repository at this point in the history
run ci
  • Loading branch information
flotwig committed Feb 1, 2023
1 parent e9b0b26 commit 18b232b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
4 changes: 2 additions & 2 deletions packages/driver/cypress/e2e/e2e/origin/snapshots.cy.ts
Expand Up @@ -74,7 +74,7 @@ describe('cy.origin - snapshots', { browser: '!webkit' }, () => {
cy.get('a[data-cy="xhr-fetch-requests-onload"]').click()
})

// TODO: the xhr event is showing up twice in the log, which is wrong and causing flake. skipping until: https://github.com/cypress-io/cypress/issues/23840 is addressed.
// TODO: fix failing test: https://github.com/cypress-io/cypress/issues/23840
it.skip('verifies XHR requests made while a secondary origin is active eventually update with snapshots of the secondary origin', () => {
cy.origin('http://www.foobar.com:3500', () => {
// need to set isInteractive in the spec bridge in order to take xhr snapshots in run mode, similar to how isInteractive is set within support/defaults.js
Expand All @@ -100,7 +100,7 @@ describe('cy.origin - snapshots', { browser: '!webkit' }, () => {
})
})

// TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23437
// TODO: fix failing test: https://github.com/cypress-io/cypress/issues/23840
it.skip('verifies fetch requests made while a secondary origin is active eventually update with snapshots of the secondary origin', () => {
cy.origin('http://www.foobar.com:3500', () => {
// need to set isInteractive in the spec bridge in order to take xhr snapshots in run mode, similar to how isInteractive is set within support/defaults.js
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/cypress/e2e/e2e/origin/validation.cy.ts
Expand Up @@ -211,7 +211,7 @@ describe('cy.origin', { browser: '!webkit' }, () => {
})
})

// TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23451
// TODO: fix failing test https://github.com/cypress-io/cypress/issues/23451
it.skip('uses cy.origin twice', () => {
cy.visit('/fixtures/auth/index.html')
cy.get('[data-cy="login-idp"]').click()
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/cypress/e2e/project-setup.cy.ts
Expand Up @@ -670,7 +670,7 @@ describe('Launchpad: Setup Project', () => {
verifyScaffoldedFiles('e2e')
})

// TODO: fix flaky tests https://github.com/cypress-io/cypress/issues/23418
// TODO: fix failing test https://github.com/cypress-io/cypress/issues/23418
it.skip('takes the user to first step of ct setup when switching from app', () => {
scaffoldAndOpenProject('pristine-with-e2e-testing')
cy.visitLaunchpad()
Expand Down
2 changes: 1 addition & 1 deletion packages/server/test/integration/cypress_spec.js
Expand Up @@ -1739,7 +1739,7 @@ describe('lib/cypress', () => {
})
})

// TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23149
// TODO: fix failing test https://github.com/cypress-io/cypress/issues/23149
it.skip('passes filtered options to Project#open and sets cli config', async function () {
const open = sinon.stub(ServerE2E.prototype, 'open').resolves([])

Expand Down
9 changes: 5 additions & 4 deletions system-tests/test/record_spec.js
Expand Up @@ -344,9 +344,9 @@ describe('e2e record', () => {

setupStubbedServer(routes)

// TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23152
it('passes in parallel with group', function () {
this.retries(15)
// TODO: fix failing test https://github.com/cypress-io/cypress/issues/23152
it.skip('passes in parallel with group', function () {
this.retries(3)

return Promise.all([
systemTests.exec(this, {
Expand Down Expand Up @@ -395,7 +395,8 @@ describe('e2e record', () => {
context('metadata', () => {
setupStubbedServer(createRoutes())

it('sends Studio usage metadata', function () {
// TODO: fix failing test https://github.com/cypress-io/cypress/issues/23151
it.skip('sends Studio usage metadata', function () {
return systemTests.exec(this, {
key: 'f858a2bc-b469-4e48-be67-0876339ee7e1',
configFile: 'cypress-with-project-id.config.js',
Expand Down

0 comments on commit 18b232b

Please sign in to comment.