fix: Avoid looking up remote jquery instance if subject is not an ele…

…ment (#8300)
cypress-io · Aug 17, 2020 · 093f3e7 · 093f3e7 · cypress-bot · Aug 17, 2020
1 parent 2f835f7
commit 093f3e7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/driver/src/cy/jquery.js b/packages/driver/src/cy/jquery.js
@@ -14,14 +14,16 @@ const create = function (state) {
 
   return {
     getRemotejQueryInstance (subject) {
-      const remoteJQuery = jquery()
-
       // we make assumptions that you cannot have
       // an array of mixed types, so we only look at
       // the first item (if there's an array)
       const firstSubject = $utils.unwrapFirst(subject)
 
-      if ($dom.isElement(firstSubject) && remoteJQueryisNotSameAsGlobal(remoteJQuery)) {
+      if (!$dom.isElement(firstSubject)) return
+
+      const remoteJQuery = jquery()
+
+      if (remoteJQueryisNotSameAsGlobal(remoteJQuery)) {
         const remoteSubject = remoteJQuery(subject)
 
         return remoteSubject