misc: add documentation for uncaught exceptions for within cy.origin() #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jennifer-shehane
requested changes
May 2, 2024
| @@ -194,6 +194,18 @@ Cypress.on('uncaught:exception', (err, runnable) => { | |||
| }) | |||
| ``` | |||
|
|
|||
| If within the `cy.origin()` command, uncaught exceptions need to be turned off from within the command. | |||
There was a problem hiding this comment.
Suggested change
| If within the `cy.origin()` command, uncaught exceptions need to be turned off from within the command. | |
| If an uncaught exception is thrown from a domain within a `cy.origin()` command, the uncaught exception handler will need to added within the `cy.origin()` command to take effect. |
There was a problem hiding this comment.
addressed in 18955e1
AtofStryker
force-pushed
the
misc/add_cy_origin_uncaught_exception_documentation
branch
from
2670f39
to
18955e1
Compare
jennifer-shehane
approved these changes
May 2, 2024
jennifer-shehane
deleted the
misc/add_cy_origin_uncaught_exception_documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for handling uncaught exceptions for within
cy.origin()