Update validation error scenarios #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4 tasks
chrisbreiding
requested changes
Nov 7, 2022
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
BlueWinds
reviewed
Nov 28, 2022
| @@ -396,13 +404,6 @@ function validate() { | |||
| cy.visit('/account', { failOnStatusCode: false }) | |||
| cy.url().should('match', /^/account/) | |||
| } | |||
|
|
|||
| // Or just return false if the session is invalid | |||
There was a problem hiding this comment.
Do we not want an example for "the validate function returns a Promise that resolves to false or rejects" anymore?
There was a problem hiding this comment.
I'm going to do more comprehensive evaluation for the docs for the v12 release.
BlueWinds
approved these changes
Nov 28, 2022
AtofStryker
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs PR for cypress-io/cypress#24511