Deprecation updates for the nodeVersion config option
#4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
jennifer-shehane
requested changes
Nov 2, 2021
Comment on lines
144
to
146
| As of version 9.0.0, Cypress will use the same version of node that was used to launch the cypress App via the CLI. | ||
|
|
||
| Prior to version 9.0.0, Cypress would use the version of node bundled with Cypress itself. |
There was a problem hiding this comment.
We don't keep notes like this in our docs for previous versions, the docs always reflect current version. In some cases we have a 'History' section in the file to explain changes
Can you update this section to reflect the truth of the new version?
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
emilyrohrbough
approved these changes
Nov 3, 2021
jennifer-shehane
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of issue #18684, This PR updates the documentation to declare the
nodeVersionconfig as deprecated as well as explain the defaultsystemand behaviour, to use the same node binary that was used to launch cypress from the cli.