Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename uses of whitelist for renamed options. #2928

Merged
merged 2 commits into from Jun 30, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane marked this pull request as draft June 25, 2020 08:18
@jennifer-shehane jennifer-shehane changed the base branch from develop to 5.0.0-release June 25, 2020 08:18
@jennifer-shehane jennifer-shehane mentioned this pull request Jun 26, 2020
14 tasks
@brian-mann
Copy link
Member

Curious why this is still a draft PR? Is it ready to be merged?

@jennifer-shehane jennifer-shehane marked this pull request as ready for review June 30, 2020 06:29
@jennifer-shehane
Copy link
Member Author

@brian-mann I make the PRs draft to prevent them from being merged before the feature is merged. Kind of like the WIP status check.

@jennifer-shehane jennifer-shehane merged commit d607100 into 5.0.0-release Jun 30, 2020
@matthamil matthamil deleted the rename-whitelist-apis branch April 14, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants