add libgbm-dev to 8.0.0 base image

[flotwig]

to fix https://circleci.com/gh/cypress-io/cypress/377914?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

on cypress-io/cypress#7791

@bahmutov since this is an update to an existing image, will it need to be manually uploaded to docker hub?

[bahmutov]

@flotwig is this for breaking change release v5? Because we won't support Node 8 I think, so we don't need this image

[flotwig]

@bahmutov Yeah, but the PR for Node 10 isn't done yet, so I'm updating this image to unblock the Electron 9 upgrade PR. Figured it was the simplest way to decouple the work.

[bahmutov]

ughh, I really, really, really would not want to update the existing image, since people have been using it for a while and can get new versions of a lib there. Very dangerous.

[flotwig]

I can add the apt step in that specific CI job for now instead

[bahmutov]

do the apt, it is less risky

[brian-mann]

Do we need to also update the node 10 image?

[flotwig]

@brian-mann the Node 10 base image already has it, we should update the circle.yml in the cypress repo to use base/10.0.0 as part of the Node 10 upgrade

[brian-mann]

@flotwig haven't we already done that here? https://github.com/cypress-io/cypress/pull/7650/files#diff-29944324a3cbf9f4bd0162dfe3975d88R1095

[flotwig]

@flotwig haven't we already done that here? #7650 (files)

yup looks right

[Tigge]

Did this actually need to bring in the -dev package of libgbm? Cypress isn't building anything against that library right? It is only a dependency of Chrome? Same goes for the libnotify packages I suppose.

[flotwig]

Did this actually need to bring in the -dev package of libgbm? Cypress isn't building anything against that library right? It is only a dependency of Chrome? Same goes for the libnotify packages I suppose.

I think you may be right, just libgbm would have sufficed. Would be down to improve how we do this for future docker images.

[bahmutov]

Note: Cypress now requires Node 10+ so we don’t expect anything to be done for Node 8 base images

…

Sent from my iPhone

On Aug 26, 2020, at 10:33, Zach Bloomquist ***@***.***> wrote:  Did this actually need to bring in the -dev package of libgbm? Cypress isn't building anything against that library right? It is only a dependency of Chrome? Same goes for the libnotify packages I suppose. I think you may be right, just libgbm would have sufficed. Would be down to improve how we do this for future docker images. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Tigge]

I tried using libgdm1 and libnotify4 and it worked on our local image, shaving of 80 MiB or so.