Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browsers/node12.14.1-chrome83-ff77 #330

Merged
merged 3 commits into from Jun 24, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 24, 2020

 node version:    v12.14.1
 npm version:     6.14.5
 yarn version:    1.22.4
 debian version:  10.2
 Chrome version:  Google Chrome 83.0.4103.61
 Firefox version: Mozilla Firefox 77.0
 git version:     git version 2.20.1
 whoami:          root

pre-req for Electron 9 upgrade cypress-io/cypress#7791

```
 node version:    v12.14.1
 npm version:     6.14.5
 yarn version:    1.22.4
 debian version:  10.2
 Chrome version:  Google Chrome 83.0.4103.61
 Firefox version: Mozilla Firefox 77.0
 git version:     git version 2.20.1
 whoami:          root
```

pre-req for Electron 9 upgrade cypress-io/cypress#7791
@flotwig flotwig requested a review from bahmutov June 24, 2020 15:29
bahmutov
bahmutov previously approved these changes Jun 24, 2020
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super, if it builds, it ships

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good to be accurate

@flotwig flotwig merged commit 379af32 into master Jun 24, 2020
@mjhenkes mjhenkes deleted the browsers-node12.14.1-chrome83-ff77 branch April 14, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants