Bump pytest-asyncio version #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might as well include bumping MacOS to Python 3.8 with this |
wxtim
force-pushed
the
fix.dependency_pinning
branch
from
8dcb0d5
to
3561fe3
Compare
|
No longer needed? - pytest-dev/pytest-asyncio#706 (comment) |
MetRonnie
reviewed
Apr 29, 2024
wxtim
changed the title
Entirely about bumping the macos version now. :) |
We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706 We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269 This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823 Test MacOs using Python 3.8 becuase GHA no longer providing 3.7 on that platform
wxtim
force-pushed
the
fix.dependency_pinning
branch
from
1ea9718
to
a1cedaf
Compare
oliver-sanders
approved these changes
Apr 30, 2024
MetRonnie
reviewed
Apr 30, 2024
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Apr 30, 2024
MetRonnie
changed the title
Yeah in my initial quick hot-fix I only had to tweak this for the build workflow. I mentioned that at at the time, but maybe it got lost in the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use Python 3.7 on MacOs on CI.
Exclude non-function releases of pytest-asyncio
Check List