fix to make setup.cfg work with setuptools v67.0.0 #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/cylc/cylc-flow/actions/runs/4042658912/jobs/6950630795#step:10:358 Seems to be a bug in |
Looks like it :( |
MetRonnie
reviewed
Jan 30, 2023
wxtim
force-pushed
the
tomli_format_change
branch
4 times, most recently
from
e31a6f9
to
1e23995
Compare
MetRonnie
reviewed
Jan 30, 2023
wxtim
commented
Jan 30, 2023
wxtim
force-pushed
the
tomli_format_change
branch
from
019353a
to
5d60214
Compare
wxtim
force-pushed
the
tomli_format_change
branch
from
5d60214
to
6417e6d
Compare
oliver-sanders
approved these changes
Jan 30, 2023
MetRonnie
reviewed
Jan 30, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
|
This PR was raised against master but it should have been "8.1.x", I didn't spot that. Please go through the check-list with PRs, the last check covers this. |
MetRonnie
added a commit
to MetRonnie/cylc-flow
that referenced
this pull request
Jan 30, 2023
fix to make setup.cfg work with setuptools v67.0.0
8 tasks
MetRonnie
added a commit
to MetRonnie/cylc-flow
that referenced
this pull request
Jan 30, 2023
fix to make setup.cfg work with setuptools v67.0.0
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small change to the format of the setup.cfg to make it work with the latest version of setuptools.
Non fast-tests cancelled.
See also https://github.com/pypa/setuptools/blob/v67.0.0/CHANGES.rst
(Still digging to find out what part of PEP508 or 440 was the problem)
Caused by this PR fixing.
Reference: Using setuptools comments to make requirements py version dependent