-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new SPA template #8
Conversation
cc @SteveALee |
I already updated the readme. Is more needed? I also tweaked the test but just noticed is broken due to a path error in import. BTW - should we change the routes? I think |
I want to restructure the Readme a bit. The tests were broken due to a path error, but coverage was not 100% any more, so I added two new tests. Yes, I will change the route |
One more thing for your list is to make sure create-cycle-app --flavor still works now repo changed |
Thanks for doing tests. I can cross of my list :) |
The package name stays the same, that's not a problem |
Cool.
Am looking forward to the release. It should answer a few FAQs and help
with on-boarding. Thanks for encouragement and improvements.
|
2e459e4
to
2821ec1
Compare
2821ec1
to
b0963ba
Compare
08c883f
to
6479fa6
Compare
A current version for trying out can be installed with
|
00fce0d
to
d0f5075
Compare
e6ffd20
to
dc63db3
Compare
Please update PR comment to: I stuck to the current convention of using the form |
Yes, then i will sqash&merge |
@SteveALee testing with |
7bf40c6
to
8e91a04
Compare
So, now I'm just waiting to get merge rights on |
Wh00t |
Yippee! I wonder how Github can give me notifications for releases? There aught to be a way |
The current version is working, but there is still work left to do
Add tests for counter
add onionify initState wrapper to
cyclejs-test-helpers
PR for
istanbul-instrumenter-loader
to fix webpack paths (feat: add fixWebpackSourcePath option (options.fixWebpackSourcePath
) webpack-contrib/istanbul-instrumenter-loader#70, created a forkistanbul-instrumenter-loader-fix
)Add test for speaker
PR for
storageify
to add a custom debounce time (Add custom debounce option maiermic/cycle-storageify#8)PR for
cyclic-router
sink type (Export RouterSink and HistoryAction cyclic-router#198)PR for
cyclic-router
to make it a main wrapper (Change router to main wrapper cyclic-router#200)Add test for app
Update README
PR for
@cycle/storage
to add typings (Typescript cyclejs/storage#26)