Build for macOS with ubuntu runner, support 64-bit ARM architecture on Windows and Linux #263
+2
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naotama2002
force-pushed
the
change-macos-build-runner
branch
2 times, most recently
from
97cbf64
to
cd2027d
Compare
naotama2002
changed the title
naotama2002
changed the title
naotama2002
force-pushed
the
change-macos-build-runner
branch
from
cd2027d
to
2b5f100
Compare
korosuke613
requested changes
Sep 29, 2023
There was a problem hiding this comment.
.github/workflows/ci.yml also uses macos-13 runner, so please use ubuntu-latest here as well.
assam/.github/workflows/ci.yml
Lines 50 to 52 in bfa8961
Also, please check additional comments.
For the rest, it is LGTM 👍🏼
naotama2002
force-pushed
the
change-macos-build-runner
branch
from
0611838
to
4197b33
Compare
naotama2002
force-pushed
the
change-macos-build-runner
branch
from
4197b33
to
2722ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Build for macOS with ubuntu runner
When cross-compiling for macOS, DNS resolution was handled improperly. This has been fixed by golang in version 1.20. Build on Ubuntu runner now that the problem is fixed.
🔗 References
Support 64-bit ARM architecture
✅ Test