[2.x] Add support for laravel/sanctum ^3.0 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupinitylabs
requested review from
gael-connan-cybex,
holyfabi,
jheusinger and
mszulik
gael-connan-cybex
approved these changes
Oct 24, 2022
lupinitylabs
changed the title
…m-version # Conflicts: # composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for version 3 of Sanctum, which is used when creating new Laravel apps by default. Because Protector only supported ^2.4, the attempt to use Protector in new Laravel projects will produce a composer conflict.
As it seems from reading https://github.com/laravel/sanctum/releases, Sanctum 3 mainly just dropped support for older Laravel versions, but did not introduce breaking changes besides laravel/sanctum#252, that requires an extra expires_at column for personal access tokens. As this is the obligation of the app developers using Protector and Protector is not actively managing that itself, we should be good.