Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call method after mapping #157

Closed
wants to merge 1 commit into from
Closed

Call method after mapping #157

wants to merge 1 commit into from

Conversation

mrcnpdlk
Copy link

@mrcnpdlk mrcnpdlk commented Apr 8, 2020 •
edited

Issue #142

@mrcnpdlk mrcnpdlk mentioned this pull request Apr 8, 2020
Closed
@cweiske cweiske changed the title Issue 142 Call method after mapping Apr 14, 2020
@cweiske
Copy link
Owner

cweiske commented Apr 14, 2020

  • Please rebase against the current master branch
  • Rename the variable from sDeserializePostEvent to postMappingMethodName

@mrcnpdlk
Copy link
Author

assertInternalType is deprecated for PHPUnit 8, i used assertIsString method.
Should I keep correctly or retain backward compatibility?

@cweiske
Copy link
Owner

cweiske commented Apr 15, 2020 via email

@mrcnpdlk mrcnpdlk closed this Apr 15, 2020
@mrcnpdlk mrcnpdlk reopened this Apr 15, 2020
@cweiske
Copy link
Owner

cweiske commented Apr 16, 2020

Thank you for the patch - merged!

@cweiske cweiske closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrcnpdlk @cweiske