[CI] Replace manylinux_2_24 image #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschiele
commented
Jun 7, 2022
Undo white space change
phschiele
commented
Jun 7, 2022
| @@ -63,7 +63,6 @@ jobs: | |||
| - name: Set Additional Envs | |||
| run: | | |||
| echo "PYTHON_SUBVERSION=$(echo $PYTHON_VERSION | cut -c 3-)" >> $GITHUB_ENV | |||
| echo "DEPLOY=$( [[ $GITHUB_EVENT_NAME == 'push' && $GITHUB_REF == 'refs/tags'* ]] && echo 'True' || echo 'False' )" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
This is unrelated, the DEPLOY environment variable was unused in this job.
SteveDiamond
approved these changes
Jun 8, 2022
|
Thanks @phschiele! Let's upload the M1 wheels first. |
SteveDiamond
added a commit
that referenced
this pull request
Jun 29, 2022
* origin/master: Add autoflake pre-commit; remove unused variable; remove unused pass (#1756) [New atom] dotsort (#1803) Change exception type when unsupported SCIP 4.x is installed (#1807) Atom for the Von Neumann Entropy (#1789) Exclude examples from deployment (#1804) make upload jobs pass (#1802) [CI] Replace manylinux_2_24 image (#1792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally, we chose
manylinux_2_24due to compatibility issues withmanylinux2014(see comment here).With the image potentially reaching EOL soon (pypa/manylinux#1332), this PR removes the hardcoding of the
manylinux_2_24image, which currently results inmanylinux2014being chosen. I've upgraded the version ofcibuildwheel, but I'm not sure if this solved the original problem, or just that potentially problematic dependencies have been upgraded in the meantime.See the outputs of this run to verify.
I've tested that the produced wheels can be installed on my local ubuntu 20.04 machine.
Note: From the repos where we have deployed a similar setup, only ecos-python still has
manylinux_2_24fixed. I.e., scs-python and diffcp are fine.One side effect might be that rerunning the CI to upload the M1 wheels as discussed with @rileyjmurray would also upload the
manylinux2014wheels alongside the existingmanylinux_2_24wheels if this PR here is merged first. That should hopefully not cause issues, but we can just merge and deploy the M1 wheels before this one if we want to prevent it.Type of change
Contribution checklist