Array.toReversed replaced by Array.reduceRight because of better comp…

[bsekachev]

…atibility

Motivation and context

• reduceRight supported from Chrome v3
• toReversed supported from Chrome v110

I saw some exceptions in analytics, where our users can't use slice function because their browsers are outdated.

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

• Refactor
  • Improved array reversal operations to enhance performance and maintainability.

[coderabbitai]

Warning

Rate Limit Exceeded

@bsekachev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 18 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0cfe295 and d9a3ba5.

Walkthrough

In the cvat-canvas module, a new utility function toReversed was introduced to reverse arrays using reduceRight. This function replaces direct calls to the toReversed method on arrays for reversing otherPoints and intermediatePoints.

Changes

File	Change Summary
cvat-canvas/src/typescript/sliceHandler.ts	Added toReversed function to reverse arrays using reduceRight. Replaced direct calls to array.toReversed() with toReversed(array) for otherPoints and intermediatePoints.

🐇
Arrays flipped, in code they dance,
With reduceRight, they take their chance.
Points reversed, the logic clear,
In CVAT, improvements near.
Code refined, like springtime air,
A rabbit's joy, beyond compare.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5be2246 and 0cfe295.

Files selected for processing (1)

• cvat-canvas/src/typescript/sliceHandler.ts (4 hunks)

Additional comments not posted (4)

cvat-canvas/src/typescript/sliceHandler.ts (4)

30-38: The implementation of toReversed using reduceRight is correct and well-documented.

---

308-308: Usage of toReversed for reversing otherPoints under specific conditions is appropriate.

---

326-326: Correct application of toReversed to handle the order of intermediatePoints based on intersection sequence.

---

340-340: Proper use of toReversed to manage the order of points in different contour segments.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.34%. Comparing base (5be2246) to head (d9a3ba5).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7916   +/-   ##
========================================
  Coverage    83.34%   83.34%           
========================================
  Files          380      380           
  Lines        40024    40028    +4     
  Branches      3766     3766           
========================================
+ Hits         33357    33361    +4     
  Misses        6667     6667           

Components	Coverage Δ
cvat-ui	79.23% <85.71%> (+<0.01%)	⬆️
cvat-server	87.13% <ø> (-0.01%)	⬇️