Fix login when email domain contains capital symbols and user was created after invitation to some org #7906
Conversation
|
Warning Rate Limit Exceeded@Marishka17 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe email creation logic in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| # User.objects.create_user(...) normalizes passed email and user.email can be different from original user_email | ||
| email = EmailAddress.objects.create(user=user, email=user.email, primary=True, verified=False) |
There was a problem hiding this comment.
Use normalized email to ensure case-insensitive handling.
Consider adding a comment explaining why normalization is necessary, for future maintainability.
+ # Normalize email to handle case-insensitivity
email = EmailAddress.objects.create(user=user, email=user.email, primary=True, verified=False)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| # User.objects.create_user(...) normalizes passed email and user.email can be different from original user_email | |
| email = EmailAddress.objects.create(user=user, email=user.email, primary=True, verified=False) | |
| # User.objects.create_user(...) normalizes passed email and user.email can be different from original user_email | |
| # Normalize email to handle case-insensitivity | |
| email = EmailAddress.objects.create(user=user, email=user.email, primary=True, verified=False) |
Marishka17
changed the title
Marishka17
changed the title
|
@Marishka17 please add a note to the changelog, otherwise LGTM |
...g.d/20240524_130047_maria_fix_issue_with_login_when_email_domain_contains_capital_symbols.md
Outdated
Show resolved
Hide resolved
…ail_domain_contains_capital_symbols.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7906 +/- ##
===========================================
- Coverage 83.35% 83.34% -0.01%
===========================================
Files 380 381 +1
Lines 40032 40053 +21
Branches 3766 3769 +3
===========================================
+ Hits 33367 33384 +17
- Misses 6665 6669 +4
|
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit