Fix pkg_config::target_supported missing causing build error. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my machine (a raspberry pi 4 running Manjaro), I get an error saying that pkg_config doesn't contain target_supported. I'm not too familiar with rust or how to navigate it, but after a little digging it looks like it's inside the Config type. The docs for pkg_config (https://docs.rs/pkg-config/0.3.8/pkg_config/index.html) lead me to believe that it's fine to just new() up a Config and use that. Testing done: - cargo test - cargo test --release Output of uname -a: Linux pi 5.10.81-1-MANJARO-ARM-RPI #1 SMP PREEMPT Thu Nov 25 07:43:21 CST 2021 aarch64 GNU/Linux
OMGtechy
added a commit
to OMGtechy/elfutils-rs
that referenced
this pull request
Dec 10, 2021
This should make it easier to manage pull requests; you know the state of cargo test. In this case, the build fails, but that's due to another issue fixed elsewhere (cuviper#1).
Open
cuviper
requested changes
Dec 10, 2021
There was a problem hiding this comment.
Thanks! That looks like a breaking change in rust-lang/pkg-config-rs#86, but we can work around it.
|
One more thing, we should require |
Ah, that explains why I was able to use it without changing the version. Makes sense to actually specify the one we need indeed. Pull request updated! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine (a raspberry pi 4 running Manjaro), I get an error saying that pkg_config doesn't contain target_supported.
I'm not too familiar with rust or how to navigate it, but after a little digging it looks like it's inside the Config type.
The docs for pkg_config (https://docs.rs/pkg-config/0.3.8/pkg_config/index.html) lead me to believe
that it's fine to just new() up a Config and use that.
Testing done:
Output of uname -a:
Linux pi 5.10.81-1-MANJARO-ARM-RPI #1 SMP PREEMPT Thu Nov 25 07:43:21 CST 2021 aarch64 GNU/Linux