Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Remark for markdown parsing #75

Closed
wants to merge 13 commits into from
Closed

Move to Remark for markdown parsing #75

wants to merge 13 commits into from

Conversation

sambauers
Copy link

See original conversation on #74

This PR covers all tests, currently working on updates to website documentation to align with new markdown plugin pattern.

@sambauers
Copy link
Author

Note that I have left one test failing due to Remark issue remarkjs/remark#497

@sambauers
Copy link
Author

Some sort of build issue at Travis. I was expecting it to fail, but only because there is one broken test. Seems it can't complete yarn build:js due to a missing babel module. Not sure what to do about that.

@dominikwilkowski
Copy link
Member

I'll have a look and go through the code and commit some stuff into this.... should be good to merge soon
Thanks for the work :D

@dominikwilkowski
Copy link
Member

Make sure you don't make this PR too big. Like I said in the issue best to not do any tests for now or any other things like config options and we go from there

@sambauers
Copy link
Author

Make sure you don't make this PR too big. Like I said in the issue best to not do any tests for now or any other things like config options and we go from there

Oh, too late. I got carried away. I also had to bypass my prior markdown-it implementation, so I ended up copying changes to a new repo without history. So it ended up one big commit basically.

If it helps, most of the changes are in src/parse.js, specifically in ParseMD(). I did have to modify config loading to allow for a nested object in the markdown options.

Impacts on tests was mostly differences in treatment of whitespace, and Remark has more relaxed entity encoding. There were some other places where existing renderer implementation may not have been catching everything it should have been, or maybe was too aggressive. So there are small modifications there.

@sambauers sambauers closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants