New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Remark for markdown parsing #75
Conversation
Note that I have left one test failing due to Remark issue remarkjs/remark#497 |
Some sort of build issue at Travis. I was expecting it to fail, but only because there is one broken test. Seems it can't complete |
I'll have a look and go through the code and commit some stuff into this.... should be good to merge soon |
Make sure you don't make this PR too big. Like I said in the issue best to not do any tests for now or any other things like config options and we go from there |
Oh, too late. I got carried away. I also had to bypass my prior markdown-it implementation, so I ended up copying changes to a new repo without history. So it ended up one big commit basically. If it helps, most of the changes are in Impacts on tests was mostly differences in treatment of whitespace, and Remark has more relaxed entity encoding. There were some other places where existing renderer implementation may not have been catching everything it should have been, or maybe was too aggressive. So there are small modifications there. |
See original conversation on #74
This PR covers all tests, currently working on updates to website documentation to align with new markdown plugin pattern.