Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: enable require access #190

Closed
wants to merge 1 commit into from
Closed

improvement: enable require access #190

wants to merge 1 commit into from

Conversation

eridal
Copy link

@eridal eridal commented Mar 17, 2020

This will enable the module to be required as it were a
normal library, which will allow programmatic access to the API.

// require as module
const goodFirstIssue = require('good-first-issue')

// execute the bin script
goodFirstIssue.parse([ ... args ])

@eridal eridal changed the title idea: enable require access improvement: enable require access Mar 17, 2020
This will enable the module to be required as it were a
normal library, which will allow programmatic access to the API.

```js
// require as module
const goodFirstIssue = require('good-first-issue')

// execute the bin script
goodFirstIssue.parse([ ... args ])
```
@eridal
Copy link
Author

eridal commented Mar 17, 2020

I found an unrelated issue, and though on adding the solution here, just is case comes handy for somebody..

The error happened when I was trying to generate the coverage report in html, with

npm t -- --coverageReporters=html

.. which typically will generate the coverage/index.html report, but handlebars was not happy about some properties.

The issue is well-known at jest repo (jestjs/jest#9396) so the workaround is to install handlebars v4.5.0

npm i -D handlebars@4.5.0

@eridal
Copy link
Author

eridal commented Jul 8, 2020

Any update on this one?

I find a bit ironic that this was my first attempt to submit an PR to an open source project .. anyways c'est la vie :)

@eridal eridal closed this Jul 15, 2020
@eridal eridal deleted the feature/enable-require-access branch July 15, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant