Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native ES modules #1040

Closed
wants to merge 5 commits into from
Closed

Native ES modules #1040

wants to merge 5 commits into from

Commits on Jun 28, 2021

  1. Remove UMD bundles

    @matt-allan
    matt-allan committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ee6f6cc View commit details
    Browse the repository at this point in the history

  2. Convert bundlewatch config to JSON 

    Bundlewatch can't load native ES modules and we don't need this
to be a JS file, so converting it to JSON allows us to switch to
native ES modules.
    @matt-allan
    matt-allan committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    5edc9ad View commit details
    Browse the repository at this point in the history

  3. Switch to native ES Modules 

    This will allow us to drop CommonJS builds and use the same ES module
build in Node, the browser, etc. Node.JS 10 was the last version that
didn't support ES modules and it's not obsolete.
    @matt-allan
    matt-allan committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    306617e View commit details
    Browse the repository at this point in the history

  4. Drop the CJS build 

    We don't need this anymore since Node can load the ES build.
    @matt-allan
    matt-allan committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    9ffae0a View commit details
    Browse the repository at this point in the history

  5. Keep CommonJS for now 

    @emotion/styled isn't compatible with native ES modules yet. We will
need to continue supporting CommonJS until it's possible to load
Radiance components in Node with native ES modules. This doesn't
preclude us from using native ES modules ourselves.

See emotion-js/emotion#2413.
    @matt-allan
    matt-allan committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    31a0491 View commit details
    Browse the repository at this point in the history