refac: refactoring nodeType by adding a NODE_TYPE object #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice, I like that idea, thank you! Would you mind re-sending the PR? We worked on stuff in the meantime and don't want to clear the conflicts manually 馃槢 Thanks! |
@cure53 Of course! I have updated and committed again. Thank you! 馃 |
|
Epic, thank you 馃檪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi! 馃憢 @cure53
It seems that there is a very slight inconvenience in understanding the code because
nodeTypeis currently compared by numbers.I'm hoping that by adding a
NODE_TYPEobject, we can provide more readable code!ENTITY_REFERENCE_NODE(5),ENTITY_NODE(6), andNOTATION_NODE(7)are deprecated, but I've added all of them.MDN-NodeType