Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ test case for #372 #374

Closed
wants to merge 1 commit into from

Conversation

peterblazejewicz
Copy link

Add test case for sanitizing white space character returning empty
string. This bounds the behaviour with test case.

See: #372

Add test case for sanitizing white space character returning empty
string.

See: cure53#372
@cure53
Copy link
Owner

cure53 commented Oct 21, 2019

Hmm, does this not collide with #373?

@cure53
Copy link
Owner

cure53 commented Oct 21, 2019

I think this is what we want, no?

3a30371

Fixes the crash and restores correct white-space behavior.

@peterblazejewicz
Copy link
Author

Nope, I've added test for a behaviour we discussed today, exhibited on the website version. Now I see that's no longer relevant.
The test should probably cover the another use case with longer white space string (so it proves no trimming behaviour happens, as it was before).
Closing this one, thanks for the head ups!

@cure53
Copy link
Owner

cure53 commented Oct 21, 2019

Ah, all good then :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants