fix: Fixed an off-by-one with the nesting counter causing over-saniti…

…zation
cure53 · Apr 23, 2024 · f051738 · f051738
1 parent c725ce0
commit f051738
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/dist/purify.cjs.js b/dist/purify.cjs.js
diff --git a/dist/purify.cjs.js.map b/dist/purify.cjs.js.map
diff --git a/dist/purify.es.mjs b/dist/purify.es.mjs
@@ -516,7 +516,7 @@ function createDOMPurify() {
   let CONFIG = null;
 
   /* Specify the maximum element nesting depth to prevent mXSS */
-  const MAX_NESTING_DEPTH = 511;
+  const MAX_NESTING_DEPTH = 512;
 
   /* Ideally, do not touch anything below this line */
   /* ______________________________________________ */
@@ -1388,7 +1388,7 @@ function createDOMPurify() {
       }
 
       /* Remove an element if nested too deeply to avoid mXSS */
-      if (depth >= MAX_NESTING_DEPTH) {
+      if (depth > MAX_NESTING_DEPTH) {
         _forceRemove(currentNode);
       }
 

diff --git a/dist/purify.es.mjs.map b/dist/purify.es.mjs.map
diff --git a/dist/purify.js b/dist/purify.js
diff --git a/dist/purify.js.map b/dist/purify.js.map
diff --git a/dist/purify.min.js b/dist/purify.min.js
diff --git a/dist/purify.min.js.map b/dist/purify.min.js.map
diff --git a/src/purify.js b/src/purify.js
@@ -389,7 +389,7 @@ function createDOMPurify(window = getGlobal()) {
   let CONFIG = null;
 
   /* Specify the maximum element nesting depth to prevent mXSS */
-  const MAX_NESTING_DEPTH = 511;
+  const MAX_NESTING_DEPTH = 512;
 
   /* Ideally, do not touch anything below this line */
   /* ______________________________________________ */
@@ -1511,7 +1511,7 @@ function createDOMPurify(window = getGlobal()) {
       }
 
       /* Remove an element if nested too deeply to avoid mXSS */
-      if (depth >= MAX_NESTING_DEPTH) {
+      if (depth > MAX_NESTING_DEPTH) {
         _forceRemove(currentNode);
       }