Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mock tests to ensure cupy.cuda.cub is used #3467

Merged
merged 8 commits into from
Jun 29, 2020
Merged

Add mock tests to ensure cupy.cuda.cub is used #3467

merged 8 commits into from
Jun 29, 2020

Commits on Jun 21, 2020

  1. add mock tests for cupy.cuda.cub

    @leofang
    leofang committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    1d74b48 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. simplify formatting a bit

    @leofang
    leofang committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    ae77eee View commit details
    Browse the repository at this point in the history

  2. further simplification 

    It seems if the callee is a Python def function (not cdef/cpdef), then
mock has no problem in intercepting its return value, and we don't not
need to invent a side_effect for it.
    @leofang
    leofang committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    fa9768d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. avoid using side_effect

    @leofang
    leofang committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    fcf2d34 View commit details
    Browse the repository at this point in the history

  2. remove unused import

    @leofang
    leofang committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    8ab0f11 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. more simplification

    @leofang
    leofang committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    732b643 View commit details
    Browse the repository at this point in the history

  2. support kwargs

    @leofang
    leofang committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f8c0ada View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Apply suggestions from code review

    @leofang
    leofang committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    c67c656 View commit details
    Browse the repository at this point in the history