Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for cupyx.optimizing.optimize #3397

Merged
merged 7 commits into from Jun 12, 2020
Merged

Add documentation for cupyx.optimizing.optimize #3397

merged 7 commits into from Jun 12, 2020

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jun 3, 2020

Close #3383.

@asi1024 asi1024 added the cat:document Documentation label Jun 3, 2020
@kmaehashi kmaehashi self-assigned this Jun 4, 2020
@kmaehashi
Copy link
Member

Could you also add a new docs page, like docs/source/ereference/optimize.rst?

@asi1024
Copy link
Member Author

asi1024 commented Jun 8, 2020

PTAL.

kmaehashi
kmaehashi reviewed Jun 9, 2020
View reviewed changes
docs/source/reference/optimize.rst
@@ -0,0 +1,8 @@
Automatic Kernel Parameters Optimizations
=========================================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some more information here?

  • Optuna installation is required
  • Currently it works for reduction ops only

@kmaehashi
Copy link
Member

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit fd4150d:

@kmaehashi
Copy link
Member

LGTM!

@kmaehashi kmaehashi mentioned this pull request Jun 9, 2020
Closed
4 tasks
@chainer-ci
Copy link
Member

Jenkins CI test (for commit fd4150d, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member Author

asi1024 commented Jun 9, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit fb65cfc:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit fb65cfc, target branch master) failed with status FAILURE.

@kmaehashi kmaehashi added this to the v8.0.0b4 milestone Jun 9, 2020
@leofang
Copy link
Member

leofang commented Jun 9, 2020 •
edited

Not sure if related: sphinx-doc/sphinx#7807. Making sphinx<=3.0.4 in the CI would likely fix it.

@kmaehashi
Copy link
Member

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit fb65cfc:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit fb65cfc, target branch master) failed with status FAILURE.

@asi1024 @leofang
Fix for sphinx version
4740d88 
Co-authored-by: Leo Fang <leofang@bnl.gov>
@asi1024
Copy link
Member Author

asi1024 commented Jun 10, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 4740d88:

@leofang
Copy link
Member

leofang commented Jun 10, 2020 •
edited

Still not working...😅 I guess you need to add optimizing to docs/source/reference/ext.rst?

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4740d88, target branch master) failed with status FAILURE.

@kmaehashi
Copy link
Member

cupyx.optimize was not listed in setup.py. @asi1024 will fix it.

@kmaehashi
Copy link
Member

kmaehashi commented Jun 11, 2020 •
edited

This is also needed #3427 as optuna is not installed in travis

@asi1024
Copy link
Member Author

asi1024 commented Jun 11, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 53e3dbb:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 53e3dbb, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member Author

asi1024 commented Jun 12, 2020

Merged chainer/chainer-test#578 for the doctest.
Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 53e3dbb:

@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Jun 12, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 53e3dbb, target branch master) succeeded!

@mergify mergify bot merged commit 18b8fc8 into cupy:master Jun 12, 2020
@asi1024 asi1024 deleted the optuna-docs branch June 12, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi left review comments

@leofang leofang leofang left review comments

Assignees

@kmaehashi kmaehashi

Labels
cat:document Documentation st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Milestone
v8.0.0b4
Development

Successfully merging this pull request may close these issues.

Write docs for Optuna optimization
5 participants
@asi1024 @kmaehashi @pfn-ci-bot @chainer-ci @leofang