Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added missing libraries to Docker #1432

Merged
merged 1 commit into from Apr 15, 2021
Merged

Conversation

ActuallyACat
Copy link
Contributor

Objective

Related to this issue: aws/aws-cli#6094 (comment)

We need aws-cli so I've added gcc, alpine-sdk, and python-dev.

Screenshots (if appropriate)

Checklist

  • If this contains visual changes, has it been reviewed by a designer?
  • If this introduces either a new component or a breaking change to an existing component, has it been reviewed by an advocate? (Ask in #prod_design_systems)
  • I have considered likely risks of these changes and got someone else to QA as appropriate
  • I have or will communicate these changes to the front end practice

Additional Considerations

  • Does there need to be right-to-left (RTL) options for localization and internationalization?
  • Has the test suite been updated?
  • Have you done cross-browser testing for our supported browsers?
  • Have you updated any relevant documentation or left useful comments in the code?
  • Have you reviewed Culture Amp's Web Accessibility guide Current Compliance, Going Forward, Statement and Answers for Customers?
  • If this contains substantial visual changes, especially far reaching ones, have you unlocked the Chromatic step in the pipeline?
  • Have Storybook stories been updated?

If you're new to Kaizen, please ask #prod_design_systems to set up an onboarding session to get you up to speed. If you have an urgent PR to merge before that happens, it is safest to ask in #prod_design_systems to have a design system advocate review the PR to catch any issues.

@ActuallyACat ActuallyACat merged commit f80057b into master Apr 15, 2021
@ActuallyACat ActuallyACat deleted the ally/update-docker-build branch April 15, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants