Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cue: ignore bad symlinks and unusable file types #1674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kcburge
Copy link
Contributor

@kcburge kcburge commented Apr 27, 2022

  • Ignore symlinks whose targets cannot be stat'd
  • Ignore sockets, devices, etc.

closes #1672

Signed-off-by: Kevin Burge kcburge@pm.me

@kcburge kcburge requested a review from cueckoo as a code owner April 27, 2022 21:35
@myitcv
Copy link
Member

myitcv commented Apr 28, 2022

@kcburge - thanks for working on an implementation here. Please can we first agree in #1672 what the bug/correct behaviour is? That way it saves potentially needless iterations on the PR.

@myitcv
Copy link
Member

myitcv commented Apr 28, 2022

@kcburge please also see my comment in #1670 (comment) regarding the DCO.

@kcburge kcburge force-pushed the ignore-bad-symlinks-and-irregular-files branch 2 times, most recently from 59ed280 to 16fc1d2 Compare April 28, 2022 15:07
- Ignore missing symlinks,
- Fail on symlinks that cannot be stat'd
- Only process directories and regular files

closes cue-lang#1672

Signed-off-by: Kevin Burge <kcburge@pm.me>
@kcburge kcburge force-pushed the ignore-bad-symlinks-and-irregular-files branch from 16fc1d2 to 2b449ca Compare April 28, 2022 15:26
@mvdan mvdan added the Discuss Requires maintainer discussion label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss Requires maintainer discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cue/load: Loader does not ignore irregular files
3 participants