Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elixir] Convert proto-based messages to json schema based messages #29

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Aug 17, 2022

Originally submitted by @WannesFransen1994 on the monorepo as the following PR: cucumber/common#1952

It is intended to remove protobuf from the elixir implementation and to use the json schemas instead.

For the whole history, please see the original PR

@aurelien-reeves
Copy link
Contributor Author

@WannesFransen1994 there are a few changes in that dedicated repo:

  • Makefiles are used only for code generation - not for build anymore
  • The CI is using github actions
    • one workflow per implementation: we will need a new one for elixir here: .github/workflows/test-elixir.yml
    • there is a dedicated workflow to make sure the generated code in the repo is up-to-date with the schemas

Copy link
Contributor Author

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've worked a little bit on that to comply with the new repo

What is left to do I guess is to add tests?
Using the CCK could maybe be done like perl does?

@mpkorstanje mpkorstanje self-requested a review November 17, 2022 15:31
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 17, 2022

@WannesFransen1994 for the CCK discussion #110

@luke-hill
Copy link
Contributor

Hi @WannesFransen1994 - Is there any updates on this?

@mattwynne
Copy link
Member

@WannesFransen1994 I am now working in Elixir day-to-day and although I'm still climbing the learning curve I'd certainly be been to pair with you on this if you have any time.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Apr 5, 2024

@mattwynne @luke-hill from what I understood and vaguely remember, Wannes work was subsidized and motivated by a grant. That grant has since run out. So I would not expect any more work to be done. I would ofcourse be pleasantly surprised otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants