Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Gem Bump #216

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

[Ruby] Gem Bump #216

wants to merge 75 commits into from

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Apr 23, 2024

🤔 What's changed?

Progressively updating lots of the supported packages.

  • cck has gone from v12 to v15
  • Rubocop subgems have all been updated 6-9months newer (Still a WIP)
  • Rubocop Performance introduced to codebase (Currently not actively remedied)
  • Rake / RSpec updated to latest support
  • Ruby minimum gone from 2.5 to 3.0
    • This has introduced new cop offenses and the ability to use Ruby 2.6+ and Ruby 3.0+ idioms
  • Minimum Rubygems updated to 3.2.3 to solve CI niggles

Updated file formats for non-generated files to be 1 class per file

  • ID Generation split into 2 files (UUID/Incrementing)

Message class simplified

  • Deserialization logic was very simple and only used in the Message class so this has been absorbed and helper module removed
  • Utils logic was only included in 2 areas (Only used in 1), so this also has been removed as a helper module and absorbed into the class proper

Miscellaneous changes

  • Acceptance tests now recurse correctly through all CCK examples instead of having a procedural code execution for the whole glob of CCK examples
  • The dummy messages used in a few specs have now been correctly setup inside spec/support and are now in a place to be properly extracted further into shared context's when the time allows

⚡️ What's your motivation?

Actually keeping things up to date

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill marked this pull request as ready for review May 14, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant