Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit CCK download to make PHP acceptance tests run #135

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add explicit CCK download to make PHP acceptance tests run #135

wants to merge 3 commits into from

Conversation

ciaranmcnulty
Copy link
Contributor

@ciaranmcnulty ciaranmcnulty commented Jan 6, 2023 •
edited

Fixes #134

End to end tests were skipped because the path to CCK sample data was broken during extraction from the monorepo.

  • adds a separation between unit tests and the (one) end to end test
  • makes the end to end test fail loudly if the CCK samples aren't present
  • explicitly downloads the CCK samples from GitHub during the docker build

@luke-hill
Copy link
Contributor

@ciaranmcnulty - We're releasing a major version of the CCK (v13), soon.

95% of it is ruby breaking changes, but there is one global change (2x bugfixes to attachment).

If you want to follow it: Progress is here: cucumber/compatibility-kit#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP version doesn't run end-to-end tests since monorepo split
2 participants
@ciaranmcnulty @luke-hill